Francy51/Neon-Desk
2
0
Fork 0
Code Issues 22 Pull Requests Actions Packages Projects Releases Wiki Activity

Stop substituting synthetic market data when providers fail

Browse Source 
- Replace synthetic fallback in getQuote()/getPriceHistory() with null returns
- Add QuoteResult/PriceHistoryResult types with { value, stale } structure
- Implement stale-while-revalidate: return cached value with stale=true on live fetch failure
- Cache failures for 30s to avoid hammering provider
- Update CompanyAnalysis type to use PriceData<T> wrapper
- Update task-processors to track failed/stale tickers explicitly
- Update price-history-card UI to show unavailable state and stale indicator
- Add comprehensive tests for failure cases
- Add e2e tests for null data, stale data, and live data scenarios

Resolves #14
This commit is contained in:
francy51
2026-03-14 23:37:12 -04:00
parent 5b68333a07
commit 529437c760
10 changed files with 496 additions and 230 deletions
Download Patch File Download Diff File Expand all files Collapse all files

183
lib/server/prices.ts
View File

@@ -1,38 +1,45 @@
const YAHOO_BASE = 'https://query1.finance.yahoo.com/v8/finance/chart';
const QUOTE_CACHE_TTL_MS = 1000 * 60;
const PRICE_HISTORY_CACHE_TTL_MS = 1000 * 60 * 15;
const FAILURE_CACHE_TTL_MS = 1000 * 30;
type CacheEntry<T> = {
expiresAt: number;
value: T;
export type QuoteResult = {
value: number | null;
stale: boolean;
};
const quoteCache = new Map<string, CacheEntry<number>>();
const priceHistoryCache = new Map<string, CacheEntry<Array<{ date: string; close: number }>>>();
export type PriceHistoryResult = {
value: Array<{ date: string; close: number }> | null;
stale: boolean;
};
type QuoteCacheEntry = {
expiresAt: number;
value: number | null;
};
type PriceHistoryCacheEntry = {
expiresAt: number;
value: Array<{ date: string; close: number }> | null;
};
const quoteCache = new Map<string, QuoteCacheEntry>();
const priceHistoryCache = new Map<string, PriceHistoryCacheEntry>();
function buildYahooChartUrl(ticker: string, params: string) {
return `${YAHOO_BASE}/${encodeURIComponent(ticker.trim().toUpperCase())}?${params}`;
}
function fallbackQuote(ticker: string) {
const normalized = ticker.trim().toUpperCase();
let hash = 0;
for (const char of normalized) {
hash = (hash * 31 + char.charCodeAt(0)) % 100000;
}
return 40 + (hash % 360) + ((hash % 100) / 100);
}
export async function getQuote(ticker: string): Promise<number> {
export async function getQuote(ticker: string): Promise<QuoteResult> {
const normalizedTicker = ticker.trim().toUpperCase();
const cached = quoteCache.get(normalizedTicker);
if (cached && cached.expiresAt > Date.now()) {
return cached.value;
return { value: cached.value, stale: false };
}
let quote = fallbackQuote(normalizedTicker);
const staleEntry = cached;
try {
const response = await fetch(buildYahooChartUrl(normalizedTicker, 'interval=1d&range=1d'), {
headers: {
@@ -42,11 +49,14 @@ export async function getQuote(ticker: string): Promise<number> {
});
if (!response.ok) {
if (staleEntry?.value !== null && staleEntry?.value !== undefined) {
return { value: staleEntry.value, stale: true };
}
quoteCache.set(normalizedTicker, {
value: quote,
expiresAt: Date.now() + QUOTE_CACHE_TTL_MS
value: null,
expiresAt: Date.now() + FAILURE_CACHE_TTL_MS
});
return quote;
return { value: null, stale: false };
}
const payload = await response.json() as {
@@ -57,51 +67,37 @@ export async function getQuote(ticker: string): Promise<number> {
const price = payload.chart?.result?.[0]?.meta?.regularMarketPrice;
if (typeof price !== 'number' || !Number.isFinite(price)) {
if (staleEntry?.value !== null && staleEntry?.value !== undefined) {
return { value: staleEntry.value, stale: true };
}
quoteCache.set(normalizedTicker, {
value: quote,
expiresAt: Date.now() + QUOTE_CACHE_TTL_MS
value: null,
expiresAt: Date.now() + FAILURE_CACHE_TTL_MS
});
return quote;
return { value: null, stale: false };
}
quote = price;
quoteCache.set(normalizedTicker, {
value: price,
expiresAt: Date.now() + QUOTE_CACHE_TTL_MS
});
return { value: price, stale: false };
} catch {
// fall through to cached fallback
if (staleEntry?.value !== null && staleEntry?.value !== undefined) {
return { value: staleEntry.value, stale: true };
}
quoteCache.set(normalizedTicker, {
value: null,
expiresAt: Date.now() + FAILURE_CACHE_TTL_MS
});
return { value: null, stale: false };
}
quoteCache.set(normalizedTicker, {
value: quote,
expiresAt: Date.now() + QUOTE_CACHE_TTL_MS
});
return quote;
}
export async function getQuoteOrNull(ticker: string): Promise<number | null> {
const normalizedTicker = ticker.trim().toUpperCase();
try {
const response = await fetch(buildYahooChartUrl(normalizedTicker, 'interval=1d&range=1d'), {
headers: {
'User-Agent': 'Mozilla/5.0 (compatible; FiscalClone/3.0)'
},
cache: 'no-store'
});
if (!response.ok) {
return null;
}
const payload = await response.json() as {
chart?: {
result?: Array<{ meta?: { regularMarketPrice?: number } }>;
};
};
const price = payload.chart?.result?.[0]?.meta?.regularMarketPrice;
return typeof price === 'number' && Number.isFinite(price) ? price : null;
} catch {
return null;
}
const result = await getQuote(ticker);
return result.value;
}
export async function getHistoricalClosingPrices(ticker: string, dates: string[]) {
@@ -172,13 +168,16 @@ export async function getHistoricalClosingPrices(ticker: string, dates: string[]
}
}
export async function getPriceHistory(ticker: string): Promise<Array<{ date: string; close: number }>> {
export async function getPriceHistory(ticker: string): Promise<PriceHistoryResult> {
const normalizedTicker = ticker.trim().toUpperCase();
const cached = priceHistoryCache.get(normalizedTicker);
if (cached && cached.expiresAt > Date.now()) {
return cached.value;
return { value: cached.value, stale: false };
}
const staleEntry = cached;
try {
const response = await fetch(buildYahooChartUrl(normalizedTicker, 'interval=1wk&range=20y'), {
headers: {
@@ -188,7 +187,14 @@ export async function getPriceHistory(ticker: string): Promise<Array<{ date: str
});
if (!response.ok) {
throw new Error('Quote history unavailable');
if (staleEntry?.value !== null && staleEntry?.value !== undefined) {
return { value: staleEntry.value, stale: true };
}
priceHistoryCache.set(normalizedTicker, {
value: null,
expiresAt: Date.now() + FAILURE_CACHE_TTL_MS
});
return { value: null, stale: false };
}
const payload = await response.json() as {
@@ -222,44 +228,37 @@ export async function getPriceHistory(ticker: string): Promise<Array<{ date: str
})
.filter((entry): entry is { date: string; close: number } => entry !== null);
if (points.length > 0) {
if (points.length === 0) {
if (staleEntry?.value !== null && staleEntry?.value !== undefined) {
return { value: staleEntry.value, stale: true };
}
priceHistoryCache.set(normalizedTicker, {
value: points,
expiresAt: Date.now() + PRICE_HISTORY_CACHE_TTL_MS
value: null,
expiresAt: Date.now() + FAILURE_CACHE_TTL_MS
});
return points;
return { value: null, stale: false };
}
priceHistoryCache.set(normalizedTicker, {
value: points,
expiresAt: Date.now() + PRICE_HISTORY_CACHE_TTL_MS
});
return { value: points, stale: false };
} catch {
// fall through to deterministic synthetic history
if (staleEntry?.value !== null && staleEntry?.value !== undefined) {
return { value: staleEntry.value, stale: true };
}
priceHistoryCache.set(normalizedTicker, {
value: null,
expiresAt: Date.now() + FAILURE_CACHE_TTL_MS
});
return { value: null, stale: false };
}
const now = Date.now();
const base = fallbackQuote(normalizedTicker);
const totalWeeks = 20 * 52;
const syntheticHistory = Array.from({ length: totalWeeks }, (_, index) => {
const step = (totalWeeks - 1) - index;
const date = new Date(now - step * 7 * 24 * 60 * 60 * 1000).toISOString();
const wave = Math.sin(index / 8) * 0.06;
const trend = (index - totalWeeks / 2) * 0.0009;
const close = Math.max(base * (1 + wave + trend), 1);
return {
date,
close: Number(close.toFixed(2))
};
});
priceHistoryCache.set(normalizedTicker, {
value: syntheticHistory,
expiresAt: Date.now() + PRICE_HISTORY_CACHE_TTL_MS
});
return syntheticHistory;
}
export const __pricesInternals = {
FAILURE_CACHE_TTL_MS,
PRICE_HISTORY_CACHE_TTL_MS,
QUOTE_CACHE_TTL_MS,
resetCaches() {