Francy51/Neon-Desk
2
0
Fork 0
Code Issues 22 Pull Requests Actions Packages Projects Releases Wiki Activity

Stop substituting synthetic market data when live quote/history providers fail #14

New Issue
Closed
opened 2026-03-15 01:25:53 +00:00 by Francy51 · 0 comments
Francy51 commented 2026-03-15 01:25:53 +00:00
Owner
Copy Link

The codebase currently substitutes deterministic fake market data when the upstream quote provider fails, and downstream analysis consumes that data as if it were real.

Why this is a problem:

  • Violates correctness and predictability under failure.
  • Turns provider outages into silent data corruption instead of explicit degraded state.
  • Pollutes valuation, charting, and portfolio refresh flows with fabricated values.

Observed in:

  • lib/server/prices.ts
    • fallbackQuote()
    • getQuote() fallback path
    • getPriceHistory() synthetic history fallback
  • lib/server/company-analysis.ts
    • consumes getQuote() and getPriceHistory()
  • lib/server/task-processors.ts
    • uses getQuote() during portfolio price refresh

Suggested direction:

  • Return null or a typed degraded-state result on upstream failure.
  • Preserve the last known good value only if it is explicitly marked stale.
  • Surface provider failure to callers so UI and background jobs can show a degraded state instead of fabricated numbers.
  • Add tests that fail if synthetic prices/history are emitted from live-data paths.

Acceptance criteria:

  • No live-data server path fabricates quotes or historical series.
  • Downstream consumers handle unavailable price data explicitly.
  • Failure state is observable in task output and company analysis payloads.
The codebase currently substitutes deterministic fake market data when the upstream quote provider fails, and downstream analysis consumes that data as if it were real. Why this is a problem: - Violates correctness and predictability under failure. - Turns provider outages into silent data corruption instead of explicit degraded state. - Pollutes valuation, charting, and portfolio refresh flows with fabricated values. Observed in: - `lib/server/prices.ts` - `fallbackQuote()` - `getQuote()` fallback path - `getPriceHistory()` synthetic history fallback - `lib/server/company-analysis.ts` - consumes `getQuote()` and `getPriceHistory()` - `lib/server/task-processors.ts` - uses `getQuote()` during portfolio price refresh Suggested direction: - Return `null` or a typed degraded-state result on upstream failure. - Preserve the last known good value only if it is explicitly marked stale. - Surface provider failure to callers so UI and background jobs can show a degraded state instead of fabricated numbers. - Add tests that fail if synthetic prices/history are emitted from live-data paths. Acceptance criteria: - No live-data server path fabricates quotes or historical series. - Downstream consumers handle unavailable price data explicitly. - Failure state is observable in task output and company analysis payloads.
Francy51 added the P1 label 2026-03-15 01:25:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
Critical priority
 P1
High priority
 P2
Medium priority
 P3
Low priority
No Label P1
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
coolify_deployment Francy51
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Francy51/Neon-Desk#14
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?